fix(firestore): Export Filter type from Firestore (#2192)

Co-authored-by: Dan Reynolds <me@danreynolds.ca>
firebase · May 24, 2023 · 52904f6 · 52904f6
1 parent c87f8a5
commit 52904f6
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/etc/firebase-admin.api.md b/etc/firebase-admin.api.md
@@ -255,6 +255,7 @@ export namespace firestore {
     import DocumentSnapshot = _firestore.DocumentSnapshot;
     import FieldPath = _firestore.FieldPath;
     import FieldValue = _firestore.FieldValue;
+    import Filter = _firestore.Filter;
     import Firestore = _firestore.Firestore;
     import FirestoreDataConverter = _firestore.FirestoreDataConverter;
     import GeoPoint = _firestore.GeoPoint;

diff --git a/etc/firebase-admin.firestore.api.md b/etc/firebase-admin.firestore.api.md
@@ -21,6 +21,7 @@ import { DocumentReference } from '@google-cloud/firestore';
 import { DocumentSnapshot } from '@google-cloud/firestore';
 import { FieldPath } from '@google-cloud/firestore';
 import { FieldValue } from '@google-cloud/firestore';
+import { Filter } from '@google-cloud/firestore';
 import { Firestore } from '@google-cloud/firestore';
 import { FirestoreDataConverter } from '@google-cloud/firestore';
 import { GeoPoint } from '@google-cloud/firestore';
@@ -78,6 +79,8 @@ export { FieldPath }
 
 export { FieldValue }
 
+export { Filter }
+
 export { Firestore }
 
 export { FirestoreDataConverter }

diff --git a/src/firestore/firestore-namespace.ts b/src/firestore/firestore-namespace.ts
@@ -38,6 +38,7 @@ export namespace firestore {
   export import DocumentSnapshot = _firestore.DocumentSnapshot;
   export import FieldPath = _firestore.FieldPath;
   export import FieldValue = _firestore.FieldValue;
+  export import Filter = _firestore.Filter;
   export import Firestore = _firestore.Firestore;
   export import FirestoreDataConverter = _firestore.FirestoreDataConverter;
   export import GeoPoint = _firestore.GeoPoint;

diff --git a/src/firestore/index.ts b/src/firestore/index.ts
@@ -41,6 +41,7 @@ export {
   DocumentSnapshot,
   FieldPath,
   FieldValue,
+  Filter,
   Firestore,
   FirestoreDataConverter,
   GeoPoint,

diff --git a/test/integration/firestore.spec.ts b/test/integration/firestore.spec.ts
@@ -110,6 +110,10 @@ describe('admin.firestore', () => {
     expect(typeof admin.firestore.FieldValue).to.be.not.undefined;
   });
 
+  it('admin.firestore.Filter type is defined', () => {
+    expect(typeof admin.firestore.Filter).to.be.not.undefined;
+  });
+
   it('admin.firestore.GeoPoint type is defined', () => {
     expect(typeof admin.firestore.GeoPoint).to.be.not.undefined;
   });