Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify Arrow lists #2700

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

sinistersnare
Copy link
Contributor

Today, Perspective fails to load when given an arrow with a ListArray. This PR provides minimal support for this data type by stringifying the list so it can be rendered as a string. Only a few list-element data-types are currently supported by this PR, but more can be added by this scaffolding.

@sinistersnare sinistersnare force-pushed the feature/arrow-list-stringify branch 3 times, most recently from 984295e to 43b0760 Compare August 2, 2024 19:21
Signed-off-by: Davis Silverman <davis@thedav.is>
@texodus texodus added the enhancement Feature requests or improvements label Aug 26, 2024
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 4b31e92 into finos:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants