-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finos/a11y-theme-builder#876: adding support for prettier #948
Conversation
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Question - will a precommit hook be implemented to run prettier on changed files prior to committing? Or should that be a separate issue? I've worked on frontend projects with precommit hooks and prettier before, and it makes reviewing PRs much smoother in my experience since we can focus on code content and be reassured that formatting was automatically applied :) |
Holding off on review until Aaron is back to answer the above question. |
I'm fine with a precommit hook |
@kburk1997 I was looking at pre-commit hooks in Git. Particularly how to get them to work with a GitHub repo: https://stackoverflow.com/questions/427207/can-git-hook-scripts-be-managed-along-with-the-repository. What approaches did your other projects use w.r.t. pre-commit hooks? I think putting our hooks into a folder in the repo and than asking developers to update their git config to point to them would be the best way. Of course, can't force people to do that. And it requires git version >= 2.9, which I know I personally don't have on either of my machines, so guessing a great many people also don't have this version. Nothing insurmountable, but another hurdle. |
This works for me when put in
|
Per discussion in yesterday's Theme Builder call, I opened a separate issue for creating a pre-commit hook for running prettier and linting -> #960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shear volume of changes are due to the reformatting of the entire code base with prettier - looks good to me!
Took code that @ravjot07 originally put in to make prettier work, so he should get credit for this! I'm just pushing it through.