finos:#924 Ensure Typography Font Settings selects are properly labeled #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field has an accessible name (#primaryFontSelect) Fixes finos#924
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kburk1997
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all select fields in the Typography Font Settings page have proper labels to improve accessibility. This fixes issue #924.
Proposed Solution
Update the select fields in the Typography Font Settings page to include the necessary label attributes. This will ensure that the select fields have accessible names, as required by WCAG 4.1.2.
To test, run Accessibility Insights For Web's FastPass tool and ensure that the issue mentioned in #924 is no longer reproducible in the deploy preview.