-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main from dev #3 #913
Conversation
Created to address #798
Added proposed main headings
Added State of Open Con 24 talk link (Lise and Cody)
Paula Paul - Docs page for video recording links
Adding badge for try.a11y-theme-builder.finos.org
Removed some duplication of documentation, added section on feature requests
… theme to add a link to the header to launch our deployed Theme Builder demo in a new browser window
Update CONTRIBUTE.md
Live demo link
…ponents use of SelectProps to now use BaseSelectProps as mui changed the name in an earlier version, causing the build break
Fix dockerbuild error
#824: update dependency versions
…h 'people needing accommodations'
…sorders' replaced with 'people needing accommodations'
Grabbed a template from https://github.com/finos/software-project-blueprint/blob/main/NOTICE
Update NOTICE
Documentation Enhancement
fix #856 : Linter added for Code Cleanup
…-#889 #889: added introduction of Components
|
✅ Deploy Preview for dapper-ganache-45a60b ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/easycla |
this-commit-is-to-add-component-imagelist-issue#518
@TheJuanAndOnly99 emailed me and said that there is currently an error with the GitHub API that is reporting an EasyCLA error even though Kris fixed her email issues. He said that the CLA signature has been verified. Asking for reviews and then this PR should be good to merge. |
Given the EasyCLA issue is resolved (or expected) I'm in favor of this merge - it's quite large but I think the risk of merge issues should be easy to 'fail forward' on- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aaronreed708 - adding my approval here and happy to help with any post merge issues given the size of this batch.
Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to review Aaron - looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Aaron
Because this was ok'd by @TheJuanAndOnly99, merging. |
Update main from dev to get benefit of dependency updates, documentation updates and new enhancements.