Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main from dev #3 #913

Merged
merged 79 commits into from
Jun 7, 2024
Merged

Update main from dev #3 #913

merged 79 commits into from
Jun 7, 2024

Conversation

aaronreed708
Copy link
Contributor

Update main from dev to get benefit of dependency updates, documentation updates and new enhancements.

maoo and others added 30 commits February 19, 2024 12:54
Created to address #798
Added proposed main headings
Added State of Open Con 24 talk link (Lise and Cody)
Paula Paul - Docs page for video recording links
Adding badge for try.a11y-theme-builder.finos.org
Removed some duplication of documentation, added section on feature requests
… theme to add a link to the header to launch our deployed Theme Builder demo in a new browser window
…ponents use of SelectProps to now use BaseSelectProps as mui changed the name in an earlier version, causing the build break
…sorders' replaced with 'people needing accommodations'
Copy link

linux-foundation-easycla bot commented Jun 4, 2024

CLA Missing ID CLA Not Signed

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for dapper-ganache-45a60b ready!

Name Link
🔨 Latest commit a4fbd4b
🔍 Latest deploy log https://app.netlify.com/sites/dapper-ganache-45a60b/deploys/665f412ec8a0be000870f86f
😎 Deploy Preview https://deploy-preview-913--dapper-ganache-45a60b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit a4fbd4b
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/665f412e56975d00080a5021
😎 Deploy Preview https://deploy-preview-913--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TheJuanAndOnly99
Copy link
Member

/easycla

this-commit-is-to-add-component-imagelist-issue#518
@aaronreed708
Copy link
Contributor Author

@TheJuanAndOnly99 emailed me and said that there is currently an error with the GitHub API that is reporting an EasyCLA error even though Kris fixed her email issues. He said that the CLA signature has been verified. Asking for reviews and then this PR should be good to merge.

@PaulaPaul
Copy link
Contributor

Given the EasyCLA issue is resolved (or expected) I'm in favor of this merge - it's quite large but I think the risk of merge issues should be easy to 'fail forward' on-

Copy link
Contributor

@PaulaPaul PaulaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaronreed708 - adding my approval here and happy to help with any post merge issues given the size of this batch.
Cheers!

Copy link
Contributor

@lwnoble lwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to review Aaron - looks good.

Copy link
Contributor

@smithbk smithbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Aaron

@aaronreed708
Copy link
Contributor Author

Because this was ok'd by @TheJuanAndOnly99, merging.

@aaronreed708 aaronreed708 merged commit 0f3e393 into main Jun 7, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.