Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height options to button size #703

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add height options to button size #703

merged 5 commits into from
Oct 31, 2023

Conversation

evangk6
Copy link
Contributor

@evangk6 evangk6 commented Oct 29, 2023 •
edited
Loading

ThemBuilder changes for #601:

  • buttonHeight values are based on multiples of the gridSize
  • buttonHeight values are restricted by the minTarget

This change will break ThemeBuilder until its corresponding SDK PR is merged (finos/a11y-theme-builder-sdk#141)

@evangk6 evangk6 mentioned this pull request Oct 29, 2023
Merged
@evangk6 evangk6 mentioned this pull request Oct 29, 2023
Open
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit dcae3ad
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/653fccbea80a9800089423c0
😎 Deploy Preview https://deploy-preview-703--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evangk6 evangk6 merged commit 621ff32 into dev Oct 31, 2023
5 checks passed
@evangk6 evangk6 deleted the evangk6-601 branch October 31, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronreed708 aaronreed708 aaronreed708 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evangk6 @aaronreed708