Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TB] Settings Slider - WCAG 4.1.2: Ensures every form element has a label (input[aria-valuemax="256"]) #923

Closed
Tracked by #927
kburk1997 opened this issue Jun 5, 2024 · 3 comments
Assignees
Labels
theme builder app Theme Builder application

Comments

@kburk1997
Copy link
Contributor

Problem/Concern

When I edit small text styles and run Accessibility Insights for Web, I get the following issue:

Issue

Ensures every form element has a label (label)

Target application

A11y ThemeBuilder

Element path

input[aria-valuemax="256"]

Snippet

<input data-index="0" aria-valuenow="16" aria-orientation="horizontal" aria-valuemax="256" aria-valuemin="0" type="range" min="0" max="256" step="1" value="16" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 100%; margin: -1px; overflow: hid...

How to fix

Fix any of the following:
Form element does not have an implicit (wrapped)
Form element does not have an explicit
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element has no placeholder attribute
Element's default semantics were not overridden with role="none" or role="presentation"

Environment

Microsoft Edge version 125.0.0.0
This accessibility issue was found using Accessibility Insights for Web 2.42.0 (axe-core 4.8.4), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Screenshot

Screenshot of font size slider element where issue occurs

Proposed Solution

Ensure all sliders are properly labeled.

@kburk1997
Copy link
Contributor Author

I am now covered under my company's CCLA, so I can take this on if needed - this seems like a very small fix.

@aaronreed708
Copy link
Contributor

I am now covered under my company's CCLA, so I can take this on if needed - this seems like a very small fix.

Sure, if you have the time to fix it, that would be great! Then you can get a contributors badge! :-)

kburk1997 added a commit to kburk1997/a11y-theme-builder that referenced this issue Jun 12, 2024
… element has a label (input[aria-valuemax="256"])
aaronreed708 added a commit that referenced this issue Jun 14, 2024
#923: [TB] Fix WCAG 4.1.2 issue with Font Settings Slider
@kburk1997
Copy link
Contributor Author

PR merged - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme builder app Theme Builder application
Projects
Status: Done
Development

No branches or pull requests

2 participants