Implement ControlLora (v2) adapter #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catwell
approved these changes
Feb 14, 2024
deltheil
added a commit
that referenced
this pull request
Feb 22, 2024
The adapter set scale did not propagate the scale to the underlying zero convolutions. The value set at CTOR time was used instead. Follow up of #285
deltheil
added a commit
that referenced
this pull request
Feb 22, 2024
The adapter set scale did not propagate the scale to the underlying zero convolutions. The value set at CTOR time was used instead. Follow up of #285
rodSiry
pushed a commit
to rodSiry/refiners
that referenced
this pull request
Feb 28, 2024
The adapter set scale did not propagate the scale to the underlying zero convolutions. The value set at CTOR time was used instead. Follow up of finegrain-ai#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a ControlLoRAv2 adapter.
Only the PyraCanny and CPDS weights from Foooocus were tested.