Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat localhost as secure context #514

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Jun 14, 2024

Related: #421

This PR will allow localhost-related URLs to be treated as secure context

Copy link
Owner

@filips123 filips123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@filips123 filips123 merged commit a4e4889 into filips123:main Jul 10, 2024
2 checks passed
@iTrooz
Copy link
Contributor Author

iTrooz commented Jul 10, 2024

Hey, just wondering:
I checked this PR today for the first time since I submitted it, and I now see you pushing another commit to it.

Did github notify you that I looked at the PR or something ?

@iTrooz iTrooz deleted the localhost branch July 10, 2024 17:53
@filips123
Copy link
Owner

No, I just didn't have much time to review it until today. In that commit, I've just slightly changed the comments so they are more consistent with the others.

@iTrooz
Copy link
Contributor Author

iTrooz commented Jul 10, 2024

Ok ! Well, thank you

@filips123 filips123 added this to the 2.12.2 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants