Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reverso Context: part 1 #19 #35

Merged
merged 22 commits into from
Oct 12, 2019
Merged

Implement Reverso Context: part 1 #19 #35

merged 22 commits into from
Oct 12, 2019

Conversation

filimo
Copy link
Owner

@filimo filimo commented Oct 12, 2019

Implement Reverso Context: part 1 #19

Refactored TranslatorView
Remove ReaderTranslatorTests and ReaderTranslatorUITests
Add ReversoContextView
Fix: Add FunctionalSwift.pdf into ReaderTranslatorMac
Implement Coordinator to WebView
Change window.location for empty newUrl
Prevent second PageWebView.load invoke while launching app
 Translate selected text in Reverso Context by Google Translate
 Translate selected text in Google Translate by Reverso Context
- Implement TranslateAction
- Add back and forward Translator buttons
- WKNavigationDelegate aren't invoked
Repeat selected text by [none, Ctrl, Alt]-r key in ReversoContext
Speak selected text by Cmd in Safari
Rename Translator with GTranslator
Speak selected text by Alt+Cmd in Safari
Prevent to speak selected text by holding Alt or Cmd while selecting text with  in Safari
Prevent to speak selected text by holding Alt or Cmd while selecting text with  in Safari (fix)
Send javascript events to Safari extension through debounce
Remove WKScriptsSetup.hasSentTranslateAction
Disable sending selected text in ReversoContext  to Translator
Speak ReversoContext by press special button or Cmd or Alt
Speak selected text in `ReversoContext` by `Alt`
Send selected text in `ReversoContext` to `Translator` by `Ctrl`
Fix: Send events with empty selectedText from Safari extension
-  Support languages in GTranslator
- Support languages in ReversoContext
@filimo filimo changed the title #19 context reverso mplement Reverso Context: part 1 #19 Oct 12, 2019
@filimo filimo changed the title mplement Reverso Context: part 1 #19 Implement Reverso Context: part 1 #19 Oct 12, 2019
@filimo filimo merged commit 981ee93 into master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant