-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/impl splistore #6231
base: master
Are you sure you want to change the base?
Feat/impl splistore #6231
Conversation
app/node/node.go
Outdated
func (r *RepoKeeper) Rollback() error { | ||
ds := r.repo.Datastore() | ||
if ds == nil { | ||
fmt.Println("no blockstore found!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
返回 error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更正
app/node/node.go
Outdated
|
||
rb, ok := ds.(splitstore.Controller) | ||
if !ok { | ||
fmt.Println("split store was disabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!ok,rb 是 nil,后续使用 rb 会 panic 吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更正
} | ||
|
||
func (v *syncVisitor) Stop() { | ||
v.mutex.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有啥特殊意义?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以动态地决定什么时候停止遍历, 暂时用不到, 已经移除
SplitstoreSize SplitstoreCount
5c7e98a
to
2e41814
Compare
9623d93
to
86bf950
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6231 +/- ##
========================================
Coverage 25% 26%
========================================
Files 631 638 +7
Lines 77885 78910 +1025
========================================
+ Hits 20233 20837 +604
- Misses 54985 55348 +363
- Partials 2667 2725 +58 |
关联的Issues (Related Issues)
close #5182
改动 (Proposed Changes)
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that: