-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: perform randomness hashing in the kernel #1842
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,10 +117,7 @@ pub enum RandomnessKind { | |
#[derive(Debug, Deserialize_tuple, PartialEq, Eq, Clone)] | ||
pub struct RandomnessRule { | ||
pub kind: RandomnessKind, | ||
pub dst: i64, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a somewhat unfortunate decrease in test vector granularity that I'm guessing will also break the existing vectors we have? Any clever ideas about how we can prevent this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, we probably just need to recreate them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could, in theory, preserve the current behavior by mocking in the kernel. But then we wouldn't be testing the randomness function. |
||
pub epoch: ChainEpoch, | ||
#[serde(with = "base64_bytes")] | ||
pub entropy: Vec<u8>, | ||
} | ||
|
||
#[derive(Debug, Deserialize, Clone)] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work?