feat: perform randomness hashing in the kernel #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Aug 14, 2023
| @@ -117,10 +117,7 @@ pub enum RandomnessKind { | |||
| #[derive(Debug, Deserialize_tuple, PartialEq, Eq, Clone)] | |||
| pub struct RandomnessRule { | |||
| pub kind: RandomnessKind, | |||
| pub dst: i64, | |||
There was a problem hiding this comment.
This is a somewhat unfortunate decrease in test vector granularity that I'm guessing will also break the existing vectors we have? Any clever ideas about how we can prevent this?
There was a problem hiding this comment.
Unfortunately, we probably just need to recreate them.
There was a problem hiding this comment.
We could, in theory, preserve the current behavior by mocking in the kernel. But then we wouldn't be testing the randomness function.
|
Also seeking feedback on whether we should make the same change on the FVM2 line, or just require clients continue to perform that work. |
This was referenced Aug 14, 2023
FVM: Simplify Randomness externs, perform hashing on the Rust side
filecoin-project/filecoin-ffi#412
Merged
arajasek
force-pushed
the
asr/randomness
branch
from
ab6c017
to
9c22c04
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
- Coverage 75.27% 75.19% -0.09%
==========================================
Files 149 149
Lines 14577 14596 +19
==========================================
+ Hits 10973 10975 +2
- Misses 3604 3621 +17
|
Stebalien
approved these changes
Aug 15, 2023
fvm/src/kernel/default.rs
Outdated
| state.write_i64::<byteorder::BigEndian>(round)?; | ||
| state.write_all(entropy)?; | ||
| let mut ret = [0u8; 32]; | ||
| ret.clone_from_slice(state.finalize().as_bytes()); |
There was a problem hiding this comment.
Suggested change
| ret.clone_from_slice(state.finalize().as_bytes()); | |
| state.finalize().as_bytes().try_into() |
Should work?
| @@ -117,10 +117,7 @@ pub enum RandomnessKind { | |||
| #[derive(Debug, Deserialize_tuple, PartialEq, Eq, Clone)] | |||
| pub struct RandomnessRule { | |||
| pub kind: RandomnessKind, | |||
| pub dst: i64, | |||
There was a problem hiding this comment.
Unfortunately, we probably just need to recreate them.
| @@ -117,10 +117,7 @@ pub enum RandomnessKind { | |||
| #[derive(Debug, Deserialize_tuple, PartialEq, Eq, Clone)] | |||
| pub struct RandomnessRule { | |||
| pub kind: RandomnessKind, | |||
| pub dst: i64, | |||
There was a problem hiding this comment.
We could, in theory, preserve the current behavior by mocking in the kernel. But then we wouldn't be testing the randomness function.
I'd actually prefer to backport it if possible. The nice thing about this patch is that it's entirely backwards compatible. Then let's immediately make the breaking changes against the |
|
Ah... but the conformance tests.... Here are the ones that pull randomness: |
|
We can probably drop them for now, but we'd definitely want to re-create them. As I noted above, technically we could keep them by moving the "replay" logic into the |
arajasek
force-pushed
the
asr/randomness
branch
from
e23eb70
to
c505cb1
Compare
arajasek
force-pushed
the
asr/randomness
branch
from
c505cb1
to
d710e06
Compare
Stebalien
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1277
We currently rely on clients like Lotus to do the hashing required for drawing randomness. This PR pulls that into the kernel.
We should eventually push the work of hashing into the actor directly, which can request it over syscalls.