feat:splitstore:retain tipset references in hot store #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
commented
Jan 3, 2023
| if pRef, err := tsRef(hdr.Parents); err != nil { | ||
| return xerrors.Errorf("error computing cid reference to parent tipset") | ||
| } else { | ||
| if err := s.walkObjectIncomplete(pRef, visitor, fHot, stopWalk); err != nil { |
There was a problem hiding this comment.
Seems likely tipsets produced before nv18 won't retroactively get references added to the store so this is an incomplete walk.
Closed
ZenGround0
force-pushed
the
splitstore/no-gc-tipset-cids
branch
from
8827fb0
to
8148783
Compare
|
Test failure is known unrelated |
arajasek
approved these changes
Jan 6, 2023
| @@ -905,6 +905,14 @@ func (s *SplitStore) walkChain(ts *types.TipSet, inclState, inclMsgs abi.ChainEp | |||
| walkCnt := new(int64) | |||
| scanCnt := new(int64) | |||
|
|
|||
| tsRef := func(cids []cid.Cid) (cid.Cid, error) { | |||
There was a problem hiding this comment.
Suggested change
| tsRef := func(cids []cid.Cid) (cid.Cid, error) { | |
| tsRef := func(blkCids []cid.Cid) (cid.Cid, error) { |
There was a problem hiding this comment.
Just so it's a bit clearer what we're doing.
| @@ -905,6 +905,14 @@ func (s *SplitStore) walkChain(ts *types.TipSet, inclState, inclMsgs abi.ChainEp | |||
| walkCnt := new(int64) | |||
| scanCnt := new(int64) | |||
|
|
|||
| tsRef := func(cids []cid.Cid) (cid.Cid, error) { | |||
| blk, err := types.NewTipSetKey(cids...).ToStorageBlock() | |||
There was a problem hiding this comment.
TipSetKey has a Cid() method you can call directly.
itests/splitstore_test.go
Outdated
| e := check.Height() | ||
| rawKey, err := check.Key().ToStorageBlock() | ||
| require.NoError(t, err) | ||
| checkRef := rawKey.Cid() |
There was a problem hiding this comment.
also directly Cid()able, I think.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#9799
Proposed Changes
FEVM is introducing H(TipSetKey) to get a single blockhash to return in places where ethereum wants a single hash. This PR ensures that splitstore compaction will keep these cids pinned in the hotstore.
Additional Info
WIP as this still needs tests
Also I don't think we're actually writing tipset references to the chain store yet if I'm right about this we'll need to do that to actually test this out.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps