fix SectorState #3881
Merged
fix SectorState #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deaswang
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Sep 16, 2020
| @@ -1,43 +1,43 @@ | |||
| package sealing | |||
|
|
|||
| type SectorState string | |||
| type SectorState uint8 | |||
There was a problem hiding this comment.
Changing this will break everyones miner sector states (this is used in on-disk state). Using strings also makes it much easier to migrate states.
The correct fix for this issue is likely just having a list of valid states, and checking against that list in the update-state command
deaswang
force-pushed
the
issue-3626-SectorState
branch
from
a03f37e
to
ed74091
Compare
magik6k
reviewed
Sep 16, 2020
| @@ -2,6 +2,8 @@ package sealing | |||
|
|
|||
| type SectorState string | |||
|
|
|||
| var ExistSectorStateList = make(map[SectorState]struct{}) | |||
There was a problem hiding this comment.
Initializing the values here instead of in init would be cleaner / safer
Suggested change
| var ExistSectorStateList = make(map[SectorState]struct{}) | |
| var ExistSectorStateList = map[SectorState]struct{}{ | |
| Empty: {}, | |
| ... | |
| } |
|
(also looks like we need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3626
update SectorState type.