Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to remove sectors that are in invalid state. #3982

Closed
jennijuju opened this issue Sep 24, 2020 · 8 comments · Fixed by #5962
Closed

Be able to remove sectors that are in invalid state. #3982

jennijuju opened this issue Sep 24, 2020 · 8 comments · Fixed by #5962
Labels
area/ux Area: UX kind/bug Kind: Bug P3 P3: Might get resolved

Comments

@jennijuju
Copy link
Member

This is for removing the sectors caused by #3626

Sectors that are being updated to a invalid state via updated-state due to a typo in the new status/mis-usage, they cannot be removed or updated to a right state (both operation lead state machine shutdown).

It will be really nice if we can have a CLI to delete the sector and its data regardless the fsm.

@jennijuju jennijuju added area/ux Area: UX kind/bug Kind: Bug P3 P3: Might get resolved labels Sep 24, 2020
@jennijuju
Copy link
Member Author

Note: miners can removed the data and free up the space and pledge new sectors. These sectors are not verified so doesnt really hurt.

@alison-man
Copy link

I met the same trouble, why lab do not fix it!

@hengic
Copy link

hengic commented Oct 20, 2020

could the Filecoin team implement this feature in the near future? I really need it to handle my invalid sectors.

@arajasek
Copy link
Contributor

Should be doable, would be helpful to have a trace of how this currently fails

@arajasek
Copy link
Contributor

If we can't get a trace of how this fails, we could always re-create the problem by reverting #3881, and then investigate further

@TippyFlitsUK
Copy link
Contributor

This occurred prior to the spell checking safety feature when doing lotus-miner sectors update-state.

As an example I have 2 sectors with a status of SealPreCommitFailed which I created by mistake during Space Race 1.

The sectors are terminated but when I try to remove or update the state again I receive the following messages:

lotus-miner sectors update-state --really-do-it 90 Removed
ERROR: normal shutdown of state machine

lotus-miner sectors remove --really-do-it 90
ERROR: normal shutdown of state machine

Many thanks!!

@arajasek
Copy link
Contributor

arajasek commented Apr 5, 2021

Okay, so this is likely failing because a planner cannot be found for the current meaningless state we're stuck in. We can special-case to not fail for update states, and then we should be good.

@jburnett
Copy link

jburnett commented Apr 8, 2021

Another use case: Terminating sector w/o message on chain.

{"level":"warn","ts":"2021-04-08T09:04:56.041-0400","logger":"sectors","caller":"storage-sealing/fsm.go:509","msg":"sector 19 got error event sealing.SectorTerminateFailed: checking precommit presence: sectorNumber is allocated, but PreCommit info wasn't found on chain"}

lotus-miner version 1.6.0+mainnet+git.3fc23a785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Area: UX kind/bug Kind: Bug P3 P3: Might get resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants