Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(f3): checkpoint tipsets that are finalized by F3 #12460

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

masih
Copy link
Member

@masih masih commented Sep 13, 2024

Related Issues

Proposed Changes

Once a decision is received from F3, checkpoint it in chain-store. As part of checkpointing, refactor the F3 tipset wrapper to reduce type casting.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@masih masih force-pushed the masih/checkpoint-f3-finalized-tipsets branch from 5c156a9 to f293db5 Compare September 13, 2024 11:31
@masih masih force-pushed the masih/checkpoint-f3-finalized-tipsets branch 2 times, most recently from 1ac1011 to 57c549d Compare September 13, 2024 15:09
chain/lf3/ec.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Outdated Show resolved Hide resolved
@masih masih force-pushed the masih/checkpoint-f3-finalized-tipsets branch 2 times, most recently from 0a135c4 to cca4df1 Compare September 18, 2024 11:38
@masih masih marked this pull request as ready for review September 18, 2024 12:06
Once a decision is received from F3, checkpoint it in chain-store.

As part of checkpointing, refactor the F3 tipset wrapper to reduce type
casting.

Note that go-f3 module now uses Go 1.22, which requires Lotus go module
to be updated accordingly.

Part of filecoin-project/go-f3#603
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to disable the finalize on the mainnet network right now.

@masih masih requested a review from Kubuxu September 18, 2024 13:37
@masih masih force-pushed the masih/checkpoint-f3-finalized-tipsets branch 2 times, most recently from a1c82c4 to 6acd2ca Compare September 18, 2024 14:32
build/buildconstants/params_2k.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Outdated Show resolved Hide resolved
@masih masih force-pushed the masih/checkpoint-f3-finalized-tipsets branch from 6acd2ca to 67fc818 Compare September 18, 2024 15:19
@masih masih merged commit d8d699a into master Sep 18, 2024
83 checks passed
@masih masih deleted the masih/checkpoint-f3-finalized-tipsets branch September 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants