feat(config): move Fevm.Events->Events, implement soft deprecation

[rvagg]

Closes: #11679

The Fevm.Events config options don't make sense under Fevm, particularly now that they are for "actors" in general. @jennijuju and I thought that getting them moved to the new top-level Events in v1.26.0 is going to be the least painful option because the number of users who currently touch those options is restricted to a small number that are using the eth APIs. But now, with the new actor events APIs, the circle of users who may be touching these will increase. So best act now before we have more people with these config options set in the wrong place.

Although, I've implemented a soft deprecation here. Your old config will still continue to work but you'll get a stderr warning about it and how it will be removed in a future update. Your settings will be automatically migrated to the new location. So this technically shouldn't be breaking for anyone.

• Introduce a moved:"To.New.Config" tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself.
• Look for X is DEPRECATED to hold certain fields back from documentation.
• Use toml:"omitempty" to prevent the default config output from having these deprecated values.

[jennijuju]

capture this in the changelog maybe?

[rvagg]

Added changelog docs about this. Also tested it out. Nothing in my systemd journal if I have none of the options set. If I set some of them then I get:

Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.DisableRealTimeFilterAPI' will be removed in a future release, use 'Events.DisableRealTimeFilterAPI' instead
Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.DisableHistoricFilterAPI' will be removed in a future release, use 'Events.DisableHistoricFilterAPI' instead
Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.FilterTTL' will be removed in a future release, use 'Events.FilterTTL' instead
Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.MaxFilters' will be removed in a future release, use 'Events.MaxFilters' instead
Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.MaxFilterResults' will be removed in a future release, use 'Events.MaxFilterResults' instead
Mar 11 13:15:35 fletcher lotus-calibnet[2677403]: WARNING: Use of deprecated configuration option 'Fevm.Events.MaxFilterHeightRange' will be removed in a future release, use 'Events.MaxFilterHeightRange' instead

If I set Fevm.Events.DisableRealTimeFilterAPI to true then my eth_getLogs stops working:

$ curl -s -X POST   -H "Content-Type: application/json"   --data '{"method":"Filecoin.EthGetLogs", "params": [{}],"id":1,"jsonrpc":"2.0"}' http://localhost:1235/rpc/v1
{"jsonrpc":"2.0","id":1,"error":{"code":1,"message":"method not supported"}}

If I move that to Events.DisableRealTimeFilterAPI then it still doesn't work.

If I set Fevm.Events.DisableRealTimeFilterAPI to false and Events.DisableRealTimeFilterAPI to true then it works. As expected.