fix: sync: atomically switch chains when checkpointing #11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/checkpoint-race
branch
from
7f70ac3
to
b76ab61
Compare
Stebalien
force-pushed
the
steb/checkpoint-race
branch
from
b76ab61
to
c5a2ff6
Compare
We can now atomically switch chains when checkpointing. Previously, we'd call `SetHead` followed by `SetCheckpoint`. Unfortunately, that's not atomic and the "head" could have reverted before we called `SetCheckpoint` (causing the latter to fail). Now, we just call `SetCheckpoint` and let `SetCheckpoint` adjust our head. This changes the behavior of `ChainStore.SetCheckpoint`, but `Syncer.SyncCheckpoint` is the only caller anyways.
Stebalien
force-pushed
the
steb/checkpoint-race
branch
from
c5a2ff6
to
2d126ad
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
F3
Proposed Changes
We can now atomically switch chains when checkpointing. Previously, we'd call
SetHeadfollowed bySetCheckpoint. Unfortunately, that's not atomic and the "head" could have reverted before we calledSetCheckpoint(causing the latter to fail).Now, we just call
SetCheckpointand letSetCheckpointadjust our head. This changes the behavior ofChainStore.SetCheckpoint, butSyncer.SyncCheckpointis the only caller anyways.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps