Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: networking: avoid dialing when trying to handshake peers #11262

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 8, 2023

Proposed Changes

Avoid dialing when trying to handshake peers. We're trying to handshake with connected peers, but that doesn't mean we want to re-connect if the connection was transient. Also, avoid handshaking with peers that don't support the handshake protocol.

Additional Info

Reported in slack https://filecoinproject.slack.com/archives/C03K82MU486/p1694181455279969

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner September 8, 2023 21:52
Also, avoid handshaking with peers that don't support the handshake
protocol.
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@arajasek arajasek merged commit e06604d into master Sep 12, 2023
87 checks passed
@arajasek arajasek deleted the steb/fix-dial-spam branch September 12, 2023 14:35
@arajasek arajasek mentioned this pull request Sep 12, 2023
8 tasks
Stebalien added a commit that referenced this pull request Sep 15, 2023
* fix: networking: avoid dialing when trying to handshake peers

Also, avoid handshaking with peers that don't support the handshake
protocol.

* drop unused imports

---------

Co-authored-by: Steven Allen <steven@stebalien.com>
rjan90 pushed a commit that referenced this pull request Oct 17, 2023
* fix: networking: avoid dialing when trying to handshake peers

Also, avoid handshaking with peers that don't support the handshake
protocol.

* drop unused imports

---------

Co-authored-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants