Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet: Make import handle SIGINT/SIGTERM #11190

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 21, 2023

Related Issues

Closes #4866

Proposed Changes

Make lotus wallet import handle SIGINT. When Ctrl+C when "Enter private key:" prompt is active, it now exits with:

lotus wallet import
Enter private key(not display in the terminal): 
Interrupt signal received. Exiting...

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Make `lotus wallet import` respect sigint
Consider SIGTERM as well
@rjan90 rjan90 requested a review from a team as a code owner August 21, 2023 08:43
Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@magik6k magik6k merged commit 2ee879d into master Aug 21, 2023
87 checks passed
@magik6k magik6k deleted the fix/wallet-sigint branch August 21, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lotus wallet import ignores SIGINT
3 participants