Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:splitstore:limit moving gc threads #10621

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

ZenGround0
Copy link
Contributor

Related Issues

After recent fix #10392 should be fine but we just had a bug report that wasn't caught during test so let's let that change sit a little before incorporating in a release.

However we do want to add configuration that makes moving GC more common to the release for better disk management. This PR is a small subset of #10392 which should make moving gc less likely to cause out of sync that is really safe without more testing time.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner April 4, 2023 20:10
@ZenGround0 ZenGround0 requested a review from rjan90 April 4, 2023 20:11
@rjan90 rjan90 mentioned this pull request Apr 5, 2023
7 tasks
@arajasek
Copy link
Contributor

arajasek commented Apr 5, 2023

LGTM -- so we wanna land this in master, backport it onto the release, and then rebase #10392 on top of latest master (which will have this change)?

@arajasek arajasek merged commit f1f0d90 into master Apr 5, 2023
@arajasek arajasek deleted the feat/limit-moving-gc-threads branch April 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants