Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:splitstore:Don't enforce walking receipt tree during compaction #10502

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

ZenGround0
Copy link
Contributor

Related Issues

#10492 also breaks compaction since we were enforcing full receipt tree walk

Proposed Changes

For now walk object incomplete on receipts always

Additional Info

thanks @ribasushi for brining this one up

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 17, 2023 15:30
@arajasek arajasek merged commit 2a3dcf6 into master Mar 17, 2023
@arajasek arajasek deleted the fix/splitstore-handles-dangling-event-ptr branch March 17, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants