Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:splitstore:Badger GC of hotstore command #10387

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Mar 3, 2023

Related Issues

#10386

Proposed Changes

chain prune hot implements badger online GC of hotstore in user driven way

Additional Info

In addition to making the new feature this PR:

  • Limits total number of flatten workers to 7 as the conclusion of investigation started in Remove flatten #10353
  • Respects context during garbage collection to allow for better shutdown behavior for very low GC thresholds
  • Rename existing chain prune to chain prune compact-cold to make name more descriptive

Unsure about

  • I bumped lotus api version number, not sure if that's correct

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 3, 2023 16:20
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splistore-related changes look good.

API version really shouldn't be bumped unless really necessary.

api/version.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 64b9b53 into master Mar 7, 2023
@magik6k magik6k deleted the feat/lotus-badger-gc branch March 7, 2023 07:52
@ZenGround0 ZenGround0 mentioned this pull request Mar 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants