Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:splitstore:bug fixes #10332

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix:splitstore:bug fixes #10332

merged 1 commit into from
Feb 23, 2023

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Feb 23, 2023 •
edited
Loading

Related Issues

Proposed Changes

  • Fix 1: instead of walking tipset reference just mark it. At first we thought this was responsible for discard instability but in retrospect it is just a nice cleanup
  • Fix 2: remove discard set after compaction
  • Comments and logging improvements

Additional Info

@ZenGround0 ZenGround0 requested a review from a team as a code owner February 23, 2023 13:08
@ZenGround0 ZenGround0 requested a review from vyzo February 23, 2023 13:08
@ZenGround0 ZenGround0 merged commit 0c9f697 into master Feb 23, 2023
@ZenGround0 ZenGround0 deleted the fix/splitstore-bugs branch February 23, 2023 15:05
@Fatman13 Fatman13 mentioned this pull request Feb 27, 2023
Open
12 tasks
@ZenGround0 ZenGround0 mentioned this pull request Feb 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZenGround0 @vyzo @magik6k