Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus Node v1.29.0 Release #12343

Closed
37 tasks done
BigLep opened this issue Aug 5, 2024 · 5 comments Β· Fixed by #12425
Closed
37 tasks done

Lotus Node v1.29.0 Release #12343

BigLep opened this issue Aug 5, 2024 · 5 comments Β· Fixed by #12425
Assignees
Labels

Comments

@BigLep
Copy link
Member

BigLep commented Aug 5, 2024

Lotus Node 1.29.0 Release

πŸ˜Άβ€πŸŒ« Meta

  • Scope: Node
  • Is this linked with a network upgrade, and thus mandatory? No
  • Related network upgrade version: n/a

🚒 Estimated shipping date

Candidate Date Release URL
RC1 Week of 2024-08-19 https://github.com/filecoin-project/lotus/releases/tag/v1.29.0-rc1
Stable (non-RC) Week of 2024-09-01 https://github.com/filecoin-project/lotus/releases/tag/v1.29.0

πŸͺ’ Dependencies for releases

Note

  1. This is the set of changes that need to make it in for a given RC. This is effectively the set of changes to cherry-pick from master.
  2. They can be checked as done once they land in master.
  3. They are presented here for quick reference, but backporting is tracked in each Release Checklist.

RC1

Stable (non-RC)

βœ… Release Checklist

Before RC1

  • Open PR against RELEASE_ISSUE_TEMPLATE.md with title docs(v1.29.0): release template improvements for improving future releases.
  • Fork a new branch (release/v1.29.0 or release/miner/v1.29.0) from master and make any further release-related changes to this branch.
  • master branch Version string updates
    • bump the version(s) in build/version.go to v1.29.1-dev.
      • Ensure to update the appropriate version string based on whether you are creating a node release (NodeBuildVersion), a miner release (MinerBuildVersion), or both.
    • Run make gen && make docsgen-cli before committing changes.
    • Create a PR with title build: v1.29.1 set initial version string
    • Merge PR

RCs

RC1

Important

These PRs should be done in and target the release/v1.29.0 or release/miner/v1.29.0 branch.

Backport PR

  • All explicitly tracked items from Dependencies for releases have landed
  • Backported everything with the "backport" label
  • Removed the "backport" label from all backported PRs (no "backport" issues)
  • Create a PR with title build: backport changes for v1.29.0-rcX
    • Link to PR:
  • Merge PR

Release PR

  • Update the version string(s) in build/version.go to one ending with '-rcX'.
    • Ensure to update the appropriate version string based on whether you are creating a node release (NodeBuildVersion), a miner release (MinerBuildVersion), or both.
  • Run make gen && make docsgen-cli to generate documentation
  • Changelog prep
    • Editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas: `gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, mergedAt, .author.login, .title] | @TSV' | sort -k4
  • Create a PR with title build: release v1.29.0-rcX
  • Merge the PR
    • Opening the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC

Testing

Note

Link to any special steps for testing releases beyond ensuring CI is green. Steps can be inlined here or tracked elsewhere.

Stable (non-RC) Release

Important

These PRs should be done in and target the release/v1.29.0 or release/miner/v1.29.0 branch.

Backport PR

Release PR

  • Update the version string(s) in build/version.go to one NOT ending with '-rcX'.
    • Ensure to update the appropriate version string based on whether you are creating a node release (NodeBuildVersion), a miner release (MinerBuildVersion), or both.
  • Run make gen && make docsgen-cli to generate documentation
  • Changelog prep
    • Editorial review (e.g., callout breaking changes, new features, FIPs, actor bundles)
    • Ensure no missing content when spot checking git history
      • Example command looking at git commits: git log --oneline --graph vA.B.C.., where A.B.C correspond to the previous release.
      • Example GitHub UI search looking at merged PRs into master: https://github.com/filecoin-project/lotus/pulls?q=is%3Apr+base%3Amaster+merged%3A%3EYYYY-MM-DD
      • Example gh cli command looking at merged PRs into master and sorted by title to group similar areas: `gh pr list --repo filecoin-project/lotus --search "base:master merged:>YYYY-MM-DD" --json number,mergedAt,author,title | jq -r '.[] | [.number, mergedAt, .author.login, .title] | @TSV' | sort -k4
  • Create a PR with title build: release v1.29.0
  • Merge the PR
    • Opening the PR will trigger a CI run that will build assets, attach the assets to the GitHub release, publish the GitHub release, and create the corresponding git tag.
  • Update 🚒 Estimated shipping date table
  • Comment on this issue announcing the RC

Post-Release

❀️ Contributors

See the final release notes!

⁉️ Do you have questions?

Leave a comment in this ticket!

@BigLep BigLep pinned this issue Aug 5, 2024
BigLep added a commit that referenced this issue Aug 9, 2024
This is accumulating improvements based on lessons learned from executing #12343
@BigLep BigLep added the TPM label Aug 9, 2024
@BigLep BigLep changed the title Lotus Release v1.29.0 [WIP] Lotus Node v1.29.0 Release Aug 9, 2024
@BigLep
Copy link
Member Author

BigLep commented Aug 9, 2024

@rjan90 : FYI that the issue description has been populated with the latest https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md

I did the initial setup steps listed in the hidden comments. In the process I found a few things to edit in the template and so created the PR for that here: #12373

@BigLep
Copy link
Member Author

BigLep commented Aug 12, 2024

Replacement PR where tracking release improvements: #12378

rjan90 added a commit that referenced this issue Aug 13, 2024
* docs: update RELEASE_ISSUE_TEMPLATE.md base on v1.29.0 release execution

This is accumulating improvements based on lessons learned from executing #12343

* Update RELEASE_ISSUE_TEMPLATE.md

* Update RELEASE_ISSUE_TEMPLATE.md

* fix(ci): allow periods in PR title scope

fix(ci): allow periods in PR title scope

* fix: add delay before dismissing PR title check review

Allows GitHub to properly register the review, addressing the issue where the review wasn't being dismissed despite the PR title being updated.

* fix: PR title check workflow to dismiss review only on title edit

PR title check workflow to dismiss review only on title edit

---------

Co-authored-by: Phi <orjan.roren@gmail.com>
@rjan90
Copy link
Contributor

rjan90 commented Aug 15, 2024

2024-08-15

Updated estimated shipping dates, due to the need for landing patch releases for Lotus Node | Lotus Miner. Estimate that RC1 will be out early next week.

Candidate Date Release URL
RC1 Week of 2024-08-19

@rjan90
Copy link
Contributor

rjan90 commented Aug 23, 2024

2024-08-23

The first release candidate of Lotus Node v1.29.0 has been shipped: https://github.com/filecoin-project/lotus/releases/tag/v1.29.0-rc1

@rjan90
Copy link
Contributor

rjan90 commented Sep 2, 2024

2024-09-01

The stable release of Lotus Node v1.29.0 has been shipped: https://github.com/filecoin-project/lotus/releases/tag/v1.29.0

@rjan90 rjan90 unpinned this issue Sep 3, 2024
@BigLep BigLep changed the title [WIP] Lotus Node v1.29.0 Release Lotus Node v1.29.0 Release Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: β˜‘οΈ Done (Archive)
Development

Successfully merging a pull request may close this issue.

2 participants