Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate actor events and Receipt::events_root. #332

Merged
merged 14 commits into from
Nov 16, 2022
Merged

propagate actor events and Receipt::events_root. #332

merged 14 commits into from
Nov 16, 2022

Conversation

raulk
Copy link
Member

@raulk raulk commented Nov 9, 2022 •
edited
Loading

Part of filecoin-project/ref-fvm#1048.

This is the FFI side implementation of filecoin-project/ref-fvm#1049.
FIP at filecoin-project/FIPs#483.

TODO

Prior to merging:

@iand iand mentioned this pull request Nov 10, 2022
Merged
7 tasks
@raulk raulk mentioned this pull request Nov 13, 2022
Closed
18 tasks
vyzo
vyzo approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo cargo patches.

rust/Cargo.toml Outdated Show resolved Hide resolved
@raulk raulk marked this pull request as ready for review November 14, 2022 23:47
@raulk raulk requested a review from Stebalien November 14, 2022 23:52
Stebalien
Stebalien approved these changes Nov 15, 2022
View reviewed changes
rust/src/fvm/machine.rs Show resolved Hide resolved
raulk added a commit to filecoin-project/lotus that referenced this pull request Nov 15, 2022
@raulk
update ffi to filecoin-project/filecoin-ffi#332.
5249a35
iand added a commit to iand/lotus that referenced this pull request Nov 15, 2022
@iand
Update filecoin-ffi to filecoin-project/filecoin-ffi#332
ade75af
@raulk raulk merged commit 14151f5 into master Nov 16, 2022
@raulk raulk deleted the raulk/events branch November 16, 2022 00:23
@arajasek
Copy link
Contributor

Hey, I don't think this should have gone into master. Doing so means we can't update FFI in Lotus until the changes in https://github.com/filecoin-project/lotus/tree/feat/nv18-events land in Lotus master, which isn't a place I want to be (especially around an upgrade). In general, I think Lotus master needs to be compatible with FFI master.

Can we revert and land in a staging branch?

@arajasek arajasek mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raulk @arajasek @vyzo @Stebalien