Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LotusTrace is incompatible with Lotus's FvmExecutionTrace #335

Closed
Tracked by #936
arajasek opened this issue Nov 16, 2022 · 0 comments · Fixed by #336
Closed
Tracked by #936

LotusTrace is incompatible with Lotus's FvmExecutionTrace #335

arajasek opened this issue Nov 16, 2022 · 0 comments · Fixed by #336

Comments

@arajasek
Copy link
Contributor

As of #332, machine.rs::LotusTrace will use FVM's v3 types, which includes a change to the Receipt struct (the new events_root field).

LotusTrace gets serialized and returned to Lotus, which deserializes it into an FvmExecutionTrace. This is currently incompatible, because Lotus's Receipt structure doesn't have the new events_root field.

This is a temporary problem until Lotus properly reasons about the new versioned Receipts, but makes Lotus::master incompatible with FFI::master today, which is an undesirable place to be.

We can fix this by either having custom serialization that ignores the events_root field, or by adding a custom LotusReceipt type to LotusTrace that doesn't include this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant