POS dataset class #1
Conversation
KyloRen1
requested review from
Craq and
IronTony-Stark
and removed request for
Craq and
IronTony-Stark
Moved to Pathlib; Added typing to all methods;
(refactor) Dataset class
| if self._check_exists(): | ||
| return |
There was a problem hiding this comment.
Add warning that there is a dataset in the directory already?
If download=True it makes more sense to override an existing set to me
There was a problem hiding this comment.
In this case a person can delete previous one and download again
There was a problem hiding this comment.
Warning would be nice, but I don't think we need to override (re-download) existing dataset if download=True. If user wants to do that, they can simply delete the dataset. Anyway, it's probably for @KyloRen1 to decide what is a desired behaviour here
There was a problem hiding this comment.
I think it's fine for now. In case of feature request, we can easily add
There was a problem hiding this comment.
Well, yeah, I can agree on that. Wouldn't it be better to simply move this method out of class then? This way it may be called on demand, instead of the download flag.
There was a problem hiding this comment.
As this dataset is dedicated to a certain data I think it is better to leave it as it is
No description provided.