Merge pull request #4 from fgiova/fix/fix-default-flag-for-destroy-si…

…gner

fix: fix default destroy signer to false if signer is a singleton

.github/workflows/node.js.yml

@@ -72,6 +72,7 @@ jobs:
   release:
     runs-on: ubuntu-latest
     needs: [test, build]
+    if: github.event_name == 'push' # Release only on Push
     steps:
       - name: Check out repo
         uses: actions/checkout@v3
@@ -85,7 +86,6 @@ jobs:
       - run: npm ci
       - run: npm run build
       - name: Semantic Release
-        if: ${{ github.event_name == 'push' }} # Semantic Release only on Push
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

src/index.ts

@@ -15,6 +15,7 @@ export class MiniSQSClient {
 	private readonly signer: Signer;
 	private region: string;
 	private endpoint: string;
+	private defaultDestroySigner = true;
 
 	constructor (region: string, endpoint?: string, undiciOptions?: Pool.Options, signer?: Signer | SignerOptions) {
 		this.undiciOptions = undiciOptions;
@@ -28,11 +29,12 @@ export class MiniSQSClient {
 			this.signer = new Signer(signer);
 		}
 		else {
+			this.defaultDestroySigner = false;
 			this.signer = SignerSingleton.getSigner();
 		}
 	}
 
-	async destroy (signer = true) {
+	async destroy (signer: boolean = this.defaultDestroySigner) {
 		return Promise.all([
 			this.pool.destroy(),
 			signer && this.signer.destroy() || true