footer statistics #207
Merged
footer statistics #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add commit date to footer |
|
review notes and added test. |
kirjs
suggested changes
Jul 6, 2019
| expect(statistics.revision).toBe('hash123'); | ||
| expect(statistics.revisionAbbr).toBe('hsh'); | ||
| expect(statistics.revisionDate).toBe('2019-06-07'); | ||
| expect(statistics.generationDate).toMatch(/\d{4,}-\d\d-\d\d/); |
There was a problem hiding this comment.
just do .toMatchSnapshot() ?
Generation date will be different every time, so snapshot will not match
There was a problem hiding this comment.
would something like this work?
.toMatchSnapshot({
generationDate: expect.match(/../),
});
| </p> | ||
| <p> | ||
| Generated {{ generationDate }}, based on commit | ||
| <a href="https://github.com/nycJSorg/30-seconds-of-angular/tree/{{ revision }}" target="_blank">{{ revisionAbbr }}</a> |
There was a problem hiding this comment.
Can we have it in site metadata? We're going to move the repo soon
There was a problem hiding this comment.
I don't think this information belongs to metalsmith meta. It's much easier to change link in template.
There was a problem hiding this comment.
https://github.com/nycJSorg/30-seconds-of-angular this part certainly should not be it 10 different templates
kirjs
approved these changes
Jul 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds statistics information in the footer
closes #196