feat(snippet): web component in use #189
Conversation
|
Hey Liron, thanks for the contribution! |
|
@NothingEverHappens great, I'll mention the schemas required addition, but regarding the warning, I'm not sure I understand your comment, what do you mean by type safety? is it concerns to a typescript compiler issue recognising the custom element class type? or a name conflict in case there's an angular component with the same name of the custom element? sorry I tried to look out for more info but couldn't find something relevant so I'll appreciate if you'll give a short explanation and I'll make sure to add the warning :) |
|
Hey, Liron, I think it you have a However with |
|
@kirjs yeah, adding CUSTOM_ELEMENTS_SCHEMA allows an NgModule to contain the following: |
|
@fetis mind review changes? :) |
Now it compiles, I have to fix run time error
kirjs
changed the title
snippets/custom-elements-use.md
Outdated
| this.setAttribute('text', value); | ||
| } | ||
|
|
||
| get color() { |
There was a problem hiding this comment.
Doesn't seem like color is used here, can we drop it to simplify the demo?
There was a problem hiding this comment.
@kirjs sorry for the delay, sure I dropped it!
|
@LironHazan This is good to merge, the demo seems to be working (you can check it out here: https://codelab.fun/30/new/30-seconds-of-angular/nycJSorg/189) The only thing left - it would be awesome to simpilfy the demo a bit (throw away irrelevant stuff) |
…o feature/custom-elements-use # Conflicts: # snippets/custom-elements-use.md
ok thanks Co-Authored-By: Sergey Fetiskin <fetis26@gmail.com>
uppercase Co-Authored-By: Sergey Fetiskin <fetis26@gmail.com>
No description provided.