Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snippets) added new snippet - inner form group as a form control #153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LironHazan
Copy link

No description provided.

@fetis fetis added the snippet New snippet or snippet update label Jun 9, 2019
@NothingEverHappens
Copy link
Contributor

Hey Liron, thanks a lot for the PR!
I made a quick pass, moved things around, made the demo worked and reworded it a bit, let me know if this makes sense.

Also would be curious what other folks think.

@LironHazan
Copy link
Author

@NothingEverHappens seems ok, thanks!

@NothingEverHappens
Copy link
Contributor

Made another pass, I'm waiting on the form to start supporting editing to make sure the demo works, will merge after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snippet New snippet or snippet update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants