Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add - new snippet: Dynamic Components #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NothingEverHappens
Copy link
Contributor

Here is a new snippet. Hope you like it :)

snippets/dynamic-components.md Outdated Show resolved Hide resolved
@thekiba
Copy link
Collaborator

thekiba commented May 21, 2019

But I think using ComponentFactoryResolver — is not a good practice. Because we already have ngComponentOutlet from @angular/common and ngxComponentOutlet from @ngxd/core with auto-bindings.

So ComponentFactoryResolver interesting only if we want to create modal windows. But we have dialogs from @angular/cdk 🙀

So idk

Co-Authored-By: Andrew Grekov <hr@thekiba.io>
@NothingEverHappens
Copy link
Contributor Author

@thekiba Can we have a snippet for each of the other methods and crosslink them?

@fetis fetis added the snippet New snippet or snippet update label Jun 6, 2019
@kirjs
Copy link
Contributor

kirjs commented Jul 15, 2019

cc @thekiba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snippet New snippet or snippet update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants