-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TLS support for Spin. #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
changed the title
ref(feat-33): TLS support for Spin.
feat: TLS support for Spin.
Feb 28, 2022
fibonacci1729
force-pushed
the
feat-33
branch
3 times, most recently
from
February 28, 2022 19:56
3b9be30
to
a43331c
Compare
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
There is one more thing that should be updated, and that is the header with the full URL of a request. Lines 216 to 218 in 6651c2c
|
fibonacci1729
force-pushed
the
feat-33
branch
2 times, most recently
from
March 1, 2022 21:34
41bdf9f
to
e6ebc02
Compare
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 1, 2022
radu-matei
reviewed
Mar 2, 2022
radu-matei
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Clippy is happy, LGTM.
Thanks!
lann
reviewed
Mar 2, 2022
fibonacci1729
force-pushed
the
feat-33
branch
2 times, most recently
from
March 2, 2022 16:22
6a349cd
to
a1b05ad
Compare
The `spin-cli` now supports the `tls-key` and `tls-cert` options, e.g. ```spin up -tls-key <path/to/key> -tls-cert <path/to/cert> ...``` For convenience, the following environment variables can be set in lieu of their respective flags. ``` SPIN_TLS_CERT=<path/to/cert> SPIN_TLS_KEY=<path/to/key> ``` NOTE: Explicitly set flags take precedence over the environment. ``` export RUST_LOG=spin_engine=info,spin_http,wact=info export SPIN_TLS_CERT=crates/http/tests/local.crt.pem export SPIN_TLS_KEY=crates/http/tests/local.key.pem spin up --app templates/spin-http/spin.toml curl -k https://127.0.0.1:3000/test/hello ``` Signed-off-by: Brian Hardock <brian.hardock@fermyon.com> Co-authored-by: Michelle Dhanani <michelle@fermyon.com> Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33
The
spin-cli
now supports thetls-key
andtls-cert
options, e.g.spin up --tls-key <path/to/key> --tls-cert <path/to/cert> ...
For convenience, the following environment variables can be set in lieu of
their respective flags.
NOTE: Explicitly set flags take precedence over the environment.
Signed-off-by: Brian Hardock brian.hardock@fermyon.com
Co-authored-by: Michelle Dhanani michelle@fermyon.com