Return an empty string when attempting to paste non-text clipboard buffer #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer. Returning null Task reference was causing a crash when attempting to paste a non-text buffer.
felixse
requested changes
Oct 1, 2018
| @@ -13,7 +13,8 @@ public Task<string> GetText() | |||
| { | |||
| return content.GetTextAsync().AsTask(); | |||
| } | |||
| return null; | |||
| // Otherwise return a new task that just sends an empty string. | |||
| return new Task<string>(new Func<string>(() => "")); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Quite possibly. This was yoinked from StackOverflow because modern .NET isn't my forte. 😸
I'll change it.
|
Yeah, I had this happening once and forget to track it, thank you 👍 |
felixse
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning null Task reference was causing a crash when attempting to paste a non-text buffer.