Fixed Issue #63 #66
Fixed Issue #63 #66
Conversation
| <TextBox | ||
| <Grid HorizontalAlignment="Stretch" VerticalAlignment="Stretch"> | ||
| <ScrollViewer HorizontalAlignment="Stretch" Visibility="{x:Bind InEditMode, Converter={StaticResource TrueToVisibleConverter}, Mode=OneWay}" VerticalScrollBarVisibility="Auto"> | ||
| <StackPanel Margin="0,0,20,0"> |
There was a problem hiding this comment.
change padding to 24 to be in line with the rest of the margins/paddings
| </StackPanel> | ||
| </ScrollViewer> | ||
| <ScrollViewer HorizontalAlignment="Stretch" Visibility="{x:Bind InEditMode, Mode=OneWay, Converter={StaticResource FalseToVisibleConverter}}" VerticalScrollBarVisibility="Auto"> | ||
| <StackPanel Margin="0,0,20,0"> |
There was a problem hiding this comment.
change padding to 24 to be in line with the rest of the margins/paddings
| @@ -169,137 +171,139 @@ | |||
| RequestedTheme="{x:Bind ViewModel.SelectedTheme.Background, Mode=OneWay, Converter={StaticResource BackgroundToApplicationThemeConverter}}"> | |||
| <ContentControl.ContentTemplate> | |||
| <DataTemplate x:DataType="viewmodels:ThemeViewModel"> | |||
| <StackPanel> | |||
| <TextBlock | |||
| <ScrollViewer VerticalScrollBarVisibility="Auto" Padding="0,0,20,0"> | |||
There was a problem hiding this comment.
change padding to 24 to be in line with the rest of the margins/paddings
|
The positioning of the scrollbar in themes/profiles is a bit off, we should try to make the detail template to stretch, so that the scrollbar is on the end of the window But other than that it looks good, thanks for your help 👍 |
|
I think I've done the changes you requested. I hope I can help again on some other issues. |
|
Was no big issue, I just pushed it into this PR. |
This fixes the scrolling issue mentioned in #63