Better Menu Fix #196

fabian0010 · 2019-02-05T20:05:28Z

I fixed #173

fabian0010 · 2019-02-05T22:57:18Z

Okay after a bunch of trial and error i realized that the original better-menu branch is outdated, it should theoretically all be good now.

Todo: find out why the menu isn't animated (at least for me)

hanskokx · 2019-02-06T00:42:59Z

SORRY. 😭 -- Hans Kokx

…

On February 5, 2019 5:57:19 PM Fabian ***@***.***> wrote: Okay after a bunch of trial and error i realized that the original better-menu branch is outdated, it should theoretically all be good now. Todo: find out why the menu isn't animated (at least for me) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

hanskokx · 2019-02-06T00:44:02Z

Also... It's animated for me on 1809? And check the framework updates from my original PR... I think that has something to do with it. -- Hans Kokx

…

On February 5, 2019 5:57:19 PM Fabian ***@***.***> wrote: Okay after a bunch of trial and error i realized that the original better-menu branch is outdated, it should theoretically all be good now. Todo: find out why the menu isn't animated (at least for me) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

felixse · 2019-02-06T07:22:15Z

I think we should avoid to updated the target framework when possible. My plan for the menu is to actually use a NavigationView in minimal mode, this gives us a very system like design by default, also animations.

fabian0010 · 2019-02-06T11:25:40Z

@skipmeister123 haha it's fine ^^

@felixse yeah i thought so as well, so this branch runs on the original target framework now

oh, I didn't know about the minimal mode, I gotta check that out

fabian0010 · 2019-02-06T11:29:21Z

Oh my, that minimal mode is perfect, why didn't I find this anywhere

fabian0010 · 2019-02-06T11:39:17Z

Nevermind, to use it we'd need a greater target version

hanskokx · 2019-02-05T20:13:42Z

FluentTerminal.App/Views/MainPage.xaml

                AddCommand="{x:Bind ViewModel.AddTerminalCommand}"
                ItemsSource="{x:Bind ViewModel.Terminals, Mode=OneWay}"
                SelectedItem="{x:Bind ViewModel.SelectedTerminal, Mode=TwoWay}"
-                Visibility="{x:Bind ViewModel.ShowTabsOnTop, Mode=OneWay}" Margin="0,0,1417,0" VerticalAlignment="Stretch" />


This margin is very specific. Are there any issues when resizing?

hanskokx · 2019-02-06T14:50:19Z

I think we should avoid to updated the target framework when possible. My plan for the menu is to actually use a NavigationView in minimal mode, this gives us a very system like design by default, also animations.

I wanted to avoid that, because I think the back arrow is ugly and unnecessary.

patriksvensson · 2019-02-06T16:06:03Z

I wanted to avoid that, because I think the back arrow is ugly and unnecessary.

@skipmeister123 The back arrow is configurable.
A NavigationView sounds like a perfect fit for what you're trying to accomplish.

fabian0010 · 2019-02-06T18:18:07Z

@skipmeister123 you can deactivate the back arrow, that wouldn't be a problem, what would be a problem is that the NavigationView only seems to support said minimal mode (which only shows the button when the pane is closed) in a more recent target version

felixse · 2019-02-06T21:13:00Z

There is no PaneDisplayMode, but we should be able to achieve this by setting both threshholds to something very big

fabian0010 · 2019-02-06T22:29:49Z

No clue what you mean, but sounds good ^^

hanskokx · 2019-03-06T19:24:30Z

Hey, we could pull some Microsoft logic for handling the menu. I like how Calculator does it, anyway.
https://github.com/Microsoft/calculator/tree/master/src/Calculator

felixse · 2019-03-06T19:52:06Z

Didn't know that calculator is open source, thanks for posting this 👍
So far it looks like NavigationView is not the right thing to use. There is a lot of workaround to do because we don't navigate but try show a menu instead and not having the button somewhere over in the terminal. I think it will be easier to follow the SplitView approach with DisplayMode set to Overlay

felixse · 2019-03-08T14:24:33Z

Currently investigating in this direction:

Todo:

Add icons
Reduce height of items
Add keybinding information

What do you think?

hanskokx · 2019-03-08T14:30:07Z

Maybe add "FluentTerminal" to the bottom of the menu? It looks pretty naked right now. How does it handle vertical resizing? Is it a scroll box? -- Hans Kokx

…

On March 8, 2019 9:24:34 AM Felix ***@***.***> wrote: Currently investigating in this direction: Todo: Add icons Remove height Add keybinding information What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ericcornelissen · 2019-03-08T15:43:25Z

Looks awesome! I like the idea of adding the keybinding info, any idea on how that will look? Maybe instead of the lines you can have some sort of header (not sure what the text of the header would be though...)?

Maybe add "FluentTerminal" to the bottom of the menu? It looks pretty naked right now.

Alternatively you could move the "About" button there similar to the settings window and the Calculate app. Or perhaps "Quit"? Maybe both?

^{Maybe you can use this tool (ScreenToGif) to show what it looks like when you open the menu 😇}

hanskokx · 2019-03-08T16:11:04Z

Alternatively you could move the "About" button there similar to the settings window and the Calculate app. Or perhaps "Quit"? Maybe both?

Kinda like I did before? :P

felixse · 2019-03-08T17:41:59Z

We could also add the content of the about page there. That way we have the app name, the current version, and maybe even an update indicator there

ericcornelissen · 2019-03-08T18:12:16Z

Kinda like I did before? :P

Hehe 😅 Apparently, yes

We could also add the content of the about page there. That way we have the app name, the current version, and maybe even an update indicator there

Not a bad idea, the main argument against that I think is that it is not consistent with other UWP apps (at least in my experience). Also, it might get a little bit cluttered that way 🤔

felixse · 2019-03-18T22:00:33Z

Update:

hanskokx · 2019-03-18T22:02:50Z

I love it, but I'd like the ℹ️ icon instead of the ?

felixse · 2019-03-19T06:27:04Z

I love it, but I'd like the ℹ️ icon instead of the ?

Yes of course, I was just hacking this together and was to lazy to search for the right icon.

The bad news is that I will need to bump the TargetVersion to 1803 for this. I think we should release 0.4.0.0 first, then raise the version for 0.5.0.0

ericcornelissen · 2019-03-19T13:00:53Z

Looking nice @felixse 👌

I could give some suggestion, I'm not even sure if I would want them, nevertheless:

Somehow incorporate "New Configurable Tab" and "New Configurable Window"? I think out of those two the "New Configurable Tab" is most useful. This is basically Add 'Choose Shell' menu for opening a new tab #218 I guess.
Move "Quit" down so it is together with "About"? Not sure, it might look better?
Add a button for "Toggle full screen".

The bad news is that I will need to bump the TargetVersion to 1803 for this. I think we should release 0.4.0.0 first, then raise the version for 0.5.0.0

That's a bummer 😞 Don't know how soon you want to release 0.4.0.0, but I guess it's best to wait...

felixse · 2019-03-19T13:14:12Z

I thought about giving 'New Tab' and 'New Window' submenus with elements for each profile. Just wondering how to add the default. Maybe if you click the root menu item?

0.4.0.0 should be coming this week The plan is to merge the command PR, add the TERM_PROGRAM environment variable and some logging improvements and then release it.

ericcornelissen · 2019-03-19T13:43:49Z

I thought about giving 'New Tab' and 'New Window' submenus with elements for each profile. Just wondering how to add the default. Maybe if you click the root menu item?

I was thinking something like PaneCustomContent (although I would put the arrow at the end rather than the start in this particular use case). I'm assuming the Item 3a only shows after you clicked item 3.

Or perhaps a right click/context menu? But I don't think that is a good choice from a usability stand-point (its not obvious).

0.4.0.0 should be coming this week The plan is to merge the command PR, add the TERM_PROGRAM environment variable and some logging improvements and then release it.

Ah oke, in that case its definitely better to wait 👍

NikkyAI · 2019-03-25T14:06:31Z

I thought about giving 'New Tab' and 'New Window' submenus with elements for each profile. Just wondering how to add the default. Maybe if you click the root menu item?

how about having it read + Powershell as 2 buttons? blicking the + would open the dropdown with all non-default profiles

in gitkraken:

this works and is very intuitive, in these you can also switch the defaults by clicking on the radio buttons
i feel like quickly switching the defaults based on what kind of task i am doing might be useful, but there could also be misclicking, in that case maybe require holding a modifier key to switch defaults..
anyways the othjer mockups there also look great

felixse · 2019-08-25T10:42:34Z

How about this?

hanskokx · 2019-08-25T13:04:20Z

It's better, but not scalable. If you have a lot of bookmarked remote servers or profiles, the list will be unwieldily. Having the sidebar would allow you to scroll.

felixse · 2019-08-26T05:37:44Z

What are the chances people have more than 10 profiles? The sidebar just looks a bit off, and I don't think we should optimize for the edge case

hanskokx · 2019-08-26T11:04:38Z

I have a lot of lab boxes which I'd create profiles for. I would easily exceed 10.

fabian0010 force-pushed the better-menu branch 2 times, most recently from 50f045b to f263f53 Compare February 5, 2019 22:52

Added better menu

dfb8bb8

fabian0010 force-pushed the better-menu branch from f263f53 to dfb8bb8 Compare February 5, 2019 23:08

hanskokx reviewed Feb 6, 2019

View reviewed changes

Merge branch 'master' into pr/196

79c5993

felixse mentioned this pull request Mar 5, 2019

Add 'Choose Shell' menu for opening a new tab #218

Closed

Merge branch 'master' into pr/196

c9727be

Overlay Mode, some dropshadow, MenuFlyoutItem instead of buttons

a9f13be

ericcornelissen mentioned this pull request Mar 16, 2019

[Looking for Feedback] Roadmap #93

Closed

Merge branch 'master' into pr/196

e6e2967

target 1803, add style for menuflyoutitem

27275cb

ericcornelissen mentioned this pull request Mar 25, 2019

how to open a new tab with non-standard profile? #249

Closed

ericcornelissen mentioned this pull request Apr 7, 2019

I can't open 2 windows of terminal #305

Closed

felixse closed this Mar 31, 2020

hanskokx mentioned this pull request Apr 29, 2020

Implement a sidebar to quickly open saved connections #742

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better Menu Fix #196

Better Menu Fix #196

fabian0010 commented Feb 5, 2019

fabian0010 commented Feb 5, 2019

hanskokx commented Feb 6, 2019 via email

hanskokx commented Feb 6, 2019 via email

felixse commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

hanskokx Feb 5, 2019

hanskokx commented Feb 6, 2019

patriksvensson commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

felixse commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

hanskokx commented Mar 6, 2019

felixse commented Mar 6, 2019

felixse commented Mar 8, 2019 •

edited

Loading

hanskokx commented Mar 8, 2019 via email

ericcornelissen commented Mar 8, 2019 •

edited

Loading

hanskokx commented Mar 8, 2019

felixse commented Mar 8, 2019

ericcornelissen commented Mar 8, 2019

felixse commented Mar 18, 2019

hanskokx commented Mar 18, 2019 via email

felixse commented Mar 19, 2019

ericcornelissen commented Mar 19, 2019

felixse commented Mar 19, 2019

ericcornelissen commented Mar 19, 2019

NikkyAI commented Mar 25, 2019

felixse commented Aug 25, 2019

hanskokx commented Aug 25, 2019 via email

felixse commented Aug 26, 2019

hanskokx commented Aug 26, 2019 via email

Better Menu Fix #196

Better Menu Fix #196

Conversation

fabian0010 commented Feb 5, 2019

fabian0010 commented Feb 5, 2019

hanskokx commented Feb 6, 2019 via email

hanskokx commented Feb 6, 2019 via email

felixse commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

hanskokx Feb 5, 2019

Choose a reason for hiding this comment

hanskokx commented Feb 6, 2019

patriksvensson commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

felixse commented Feb 6, 2019

fabian0010 commented Feb 6, 2019

hanskokx commented Mar 6, 2019

felixse commented Mar 6, 2019

felixse commented Mar 8, 2019 • edited Loading

hanskokx commented Mar 8, 2019 via email

ericcornelissen commented Mar 8, 2019 • edited Loading

hanskokx commented Mar 8, 2019

felixse commented Mar 8, 2019

ericcornelissen commented Mar 8, 2019

felixse commented Mar 18, 2019

hanskokx commented Mar 18, 2019 via email

felixse commented Mar 19, 2019

ericcornelissen commented Mar 19, 2019

felixse commented Mar 19, 2019

ericcornelissen commented Mar 19, 2019

NikkyAI commented Mar 25, 2019

felixse commented Aug 25, 2019

hanskokx commented Aug 25, 2019 via email

felixse commented Aug 26, 2019

hanskokx commented Aug 26, 2019 via email

felixse commented Mar 8, 2019 •

edited

Loading

ericcornelissen commented Mar 8, 2019 •

edited

Loading