Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct SSH shell targets #39

Closed
Riebart opened this issue Jun 10, 2018 · 4 comments
Closed

Direct SSH shell targets #39

Riebart opened this issue Jun 10, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@Riebart
Copy link
Contributor

Riebart commented Jun 10, 2018

It would be handy, but not necessary, to support SSH targets as profile shells using the nodejs SSH client modules. This would be useful for working on remote machines, as well as working around #9 on Windows 10 1803 and newer by running the WSL sshd, and connecting over SSH (thereby eliminating the fact that the Windows console host currently doesn't pass control sequences around quite right).

There's a lot of features more important than this, but throwing it into the hat anyway.

@hanskokx
Copy link
Contributor

hanskokx commented Jun 10, 2018 via email

@Riebart
Copy link
Contributor Author

Riebart commented Jun 10, 2018

A perfectly valid point. It does work, but adds a required that you've got an SSH client kicking around. Specifically, if you're using the WSL ssh, it doesn't fix the 256-color issue (because you're invoking it through the WSL console host).

The advantage to using the ssh2 nodejs module (or similar) directly is that you'd be able to use this without the installing a separate SSH client. The terminal could also handle graceful reconnecting for you across network changes and sleep/wakeup cycles.

The arguments are a perfectly functional way of addressing this for now, in any event.

@hanskokx
Copy link
Contributor

hanskokx commented Jun 10, 2018 via email

@felixse
Copy link
Owner

felixse commented Jun 10, 2018

This would be a nice feature for later on, when we have all the basics implemented.
I would prefer using something like https://github.com/sshnet/SSH.NET since the javascript part of the application might go away once https://github.com/darrenstarr/VtNetCore.UWP is ready for adoption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants