[pinpoint-apm#98] Fix no details error case informations to Error ca…

…llstack

By using the string return value of the stack in the toString method of Error, the developer can check the error information in detail.
Fix redis 4.0 redis connection error
   - upgrade testcontainer to v7

.github/workflows/main.yml

@@ -20,7 +20,6 @@ jobs:
 
     name: Node ${{ matrix.node_version }} on ubuntu-latest
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v2
       - name: setup node environment
         uses: actions/setup-node@v2

.nycrc

@@ -1,3 +1,3 @@
 {
-  "exclude": ["lib/data/grpc/**/*", "test/**/*"]
+  "exclude": ["lib/data/v1/**/*", "test/**/*"]
 }

lib/context/span-event-recorder.js

@@ -126,9 +126,10 @@ class SpanEventRecorder {
   recordException(error, isError) {
     if (this.spanEvent && error) {
       const metaInfo = StringMetaService.get(error.name || 'Error')
+      const errorMessage = error && typeof error.stack === 'string' ? error.stack.split(/\r?\n/, 2).join() : ''
       this.spanEvent.exceptionInfo = {
         intValue: metaInfo.stringId,
-        stringValue: error.toString(),
+        stringValue: errorMessage,
       }
       if (this.span && isError) {
         this.span.err = 1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinpoint-node-agent",
-  "version": "0.9.0-next.1",
+  "version": "0.9.0-next.2",
   "main": "index.js",
   "scripts": {
     "test": "./node_modules/.bin/tape ./test/**/*.test.js",
@@ -86,13 +86,13 @@
     "mongoose": "^5.4.3",
     "npm-run-all": "^1.7.0",
     "nyc": "^15.1.0",
-    "redis": ">=3.1.1",
+    "redis": "^3.1.2",
     "redis-mock": "^0.49.0",
     "request": "^2.88.0",
     "rewire": "^4.0.1",
     "rimraf": "^2.6.2",
     "tap-spec": "^5.0.0",
     "tape": "^4.9.1",
-    "testcontainers": "^2.8.0"
+    "testcontainers": "^7.24.0"
   }
 }

test/agent.test.js

@@ -14,5 +14,5 @@ test('Should initialize agent', function (t) {
 
   const agent = require('./support/agent-singleton-mock')
   t.ok(agent)
-  t.equal(agent.pinpointClient.agentInfo.agentVersion, '0.9.0-next.1', 'agent version from package.json')
+  t.equal(agent.pinpointClient.agentInfo.agentVersion, '0.9.0-next.2', 'agent version from package.json')
 })

test/instrumentation/fix-async-call-stack.test.js

@@ -21,7 +21,7 @@ test(`fix redis call stack depth`, async (t) => {
     const redis = require('redis')
     const client = redis.createClient(
         container.getMappedPort(6379),
-        container.getContainerIpAddress(),
+        container.getHost(),
     )
 
     client.set("key", "value", async function (error) {

test/instrumentation/module/fix-redis.test.js

@@ -23,7 +23,7 @@ test(`redis destination id`, async (t) => {
 
     const client = redis.createClient(
         container.getMappedPort(6379),
-        container.getContainerIpAddress(),
+        container.getHost(),
     )
 
     client.on("error", function (error) {
@@ -65,7 +65,7 @@ test("ioredis destination id", async function (t) {
     const port = container.getMappedPort(6379)
     const redis = new Redis(
         port,
-        container.getContainerIpAddress(),
+        container.getHost(),
     )
     redis.on("error", function (error) {
         console.error(error)
@@ -119,7 +119,7 @@ test(`Fix app crash without callback function https://github.com/pinpoint-apm/pi
     const redis = require('redis')
 
     const client = redis.createClient({
-        host: container.getContainerIpAddress(),
+        host: container.getHost(),
         port: container.getMappedPort(6379),
         db: 3,
     })

test/instrumentation/module/http.test.js

@@ -23,9 +23,9 @@ test(`outgoing request URL escape a bug`, async (t) => {
             t.true(agent.dataSender.mockSpanChunk.spanEventList.length == 2, `spanEventList`)
 
             const spanEvent = agent.dataSender.mockSpanChunk.spanEventList[1]
-            
+
             t.equal(spanEvent.annotations[0].value.stringValue, "GET", "URL")
-            t.equal(spanEvent.annotations[1].value.stringValue, "eonet.sci.gsfc.nasa.gov/api/v2.1/categories", "URL")
+            t.equal(spanEvent.annotations[1].value.stringValue, "eonet.gsfc.nasa.gov/api/v2.1/categories", "URL")
             agent.completeTraceObject(trace)
         })
 })

test/instrumentation/module/mongodb-core.test.js

@@ -19,7 +19,7 @@ test(`mongodb`, async (t) => {
     const trace = agent.createTraceObject()
     const Server = require('mongodb-core').Server
     var server = new Server({
-        host: container.getContainerIpAddress(),
+        host: container.getHost(),
         port: container.getMappedPort(27017),
         reconnect: true,
         reconnectInterval: 50
@@ -44,27 +44,27 @@ test(`mongodb`, async (t) => {
                 },
                 ordered: true
             }, async function (err, results) {
-                t.equal(null, err);
-                t.equal(2, results.result.n);
+                t.equal(null, err)
+                t.equal(2, results.result.n)
 
                 server.destroy()
                 await container.stop()
                 agent.completeTraceObject(trace)
                 t.end()
-            });
-        });
-    });
+            })
+        })
+    })
 
     server.on('close', function () {
         console.log('mongodb-core.test.js closed')
         t.end()
-    });
+    })
 
     server.on('reconnect', function () {
-        console.log('mongodb-core.test.js reconnect');
-    });
+        console.log('mongodb-core.test.js reconnect')
+    })
 
     // Start connection
-    server.connect();
+    server.connect()
 
 })