Skip to content

Commit

Permalink
[pinpoint-apm#117] adaptor and adaptee
Browse files Browse the repository at this point in the history
  • Loading branch information
feelform committed Oct 18, 2022
1 parent 639f0ca commit 7b6e119
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 16 deletions.
30 changes: 22 additions & 8 deletions lib/supports.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,28 @@
* Apache License v2.0
*/

'use strict'
'use strict'

const Logger = require('./utils/logger')
const Logger = require('./utils/log/logger2')

function getLog() {
return {}
}
const log = new Logger.NoneBuilder({
logs: [],
debug: function (message) {
this.logs.push(message)
},
info: function (message) {
this.logs.push(message)
},
warn: function (message) {
this.logs.push(message)
},
error: function (message) {
this.logs.push(message)
}
}).build()

module.exports = {
getLog: getLog
}
module.exports = {
getLog: function () {
return log
}
}
10 changes: 6 additions & 4 deletions lib/utils/log/logger2.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@

'use strict'

const LoggerOutputAdaptor = require('./logger-output-adaptor')

class Logger {

constructor(type, adaptor) {
this.type = type
this.adaptor = adaptor
this.adaptor = new LoggerOutputAdaptor(adaptor)
}

static get DebugBuilder() {
Expand Down Expand Up @@ -51,7 +53,7 @@ class Logger {
}

isDebug() {
return this.adaptor.isDebug
return this.type.isDebug()
}

info(message) {
Expand Down Expand Up @@ -98,11 +100,11 @@ class LogType {
}

isDebug() {
return this === LogType.debug
return this.name === LogType.debug.name
}

isInfo() {
return this === LogType.info
return this.name === LogType.info.name
}
}

Expand Down
10 changes: 6 additions & 4 deletions test/utils/log/logger.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,21 @@ test('Logger.Builder', (t) => {

let actual = new Logger.DebugBuilder(expectedAdaptor).build()
t.equal(actual.type.name, 'debug', 'debug name match')
t.true(actual.adaptor === expectedAdaptor, 'adaptor member variable')
t.true(actual.adaptor.output === expectedAdaptor, 'adaptor member variable')
t.true(actual.isDebug(), 'Debug Log check')

actual = new Logger.InfoBuilder(expectedAdaptor).build()
t.equal(actual.type.name, 'info', 'info name match')
t.true(actual.adaptor === expectedAdaptor, 'adaptor member variable')
t.true(actual.adaptor.output === expectedAdaptor, 'adaptor member variable')
t.true(actual.isInfo(), 'Info log check')

actual = new Logger.WarnBuilder(expectedAdaptor).build()
t.equal(actual.type.name, 'warn', 'warn name match')
t.true(actual.adaptor === expectedAdaptor, 'adaptor member variable')
t.true(actual.adaptor.output === expectedAdaptor, 'adaptor member variable')

actual = new Logger.ErrorBuilder(expectedAdaptor).build()
t.equal(actual.type.name, 'error', 'error name match')
t.true(actual.adaptor === expectedAdaptor, 'adaptor member variable')
t.true(actual.adaptor.output === expectedAdaptor, 'adaptor member variable')

actual = new Logger.NoneBuilder(expectedAdaptor).build()
t.equal(actual.type.name, 'none', 'none name match')
Expand Down

0 comments on commit 7b6e119

Please sign in to comment.