Skip to content

Commit

Permalink
[pinpoint-apm#86] trace guard
Browse files Browse the repository at this point in the history
  • Loading branch information
feelform committed Sep 12, 2023
1 parent 035399b commit 7799027
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions lib/instrumentation/module/express.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ module.exports = function (agent, version, express) {
handle = function (err, req, res, next) {
const trace = agent.traceContext.currentTraceObject()
let spanEventRecorder = null
let handlerSpanEventRecorder = null
if (shouldReport(err, trace)) {
spanEventRecorder = trace.traceBlockBegin()
spanEventRecorder.recordServiceType(ServiceTypeCode.express)
Expand All @@ -147,9 +148,18 @@ module.exports = function (agent, version, express) {
} else {
spanEventRecorder.recordApiDesc(getDescriptionText(objectName, layerName, req.method))
}

if (handlerMethodDescriptor) {
handlerSpanEventRecorder = trace.traceBlockBegin()
handlerSpanEventRecorder.recordServiceType(ServiceTypeCode.node_method)
handlerSpanEventRecorder.recordApi(handlerMethodDescriptor)
}
}
const result = origin.apply(this, arguments)
if (trace) {
if (handlerSpanEventRecorder) {
trace.traceBlockEnd(handlerSpanEventRecorder)
}
trace.traceBlockEnd(spanEventRecorder)
}
return result
Expand Down

0 comments on commit 7799027

Please sign in to comment.