Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkts parameters are true by default #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brngylni
Copy link
Contributor

This relates to issue #79. Parameters have been made True by default.

@gridhead gridhead self-assigned this Mar 20, 2024
@gridhead gridhead self-requested a review March 20, 2024 02:53
@gridhead
Copy link
Member

@brngylni, in the /test/ directory - you need to make changes to account for the changed option sets.

Take, for instance, these lines of code https://github.com/fedora-infra/pagure-exporter/blob/main/test/test_tkts.py#L37-L48 where it is assumed that the labels, states, privacy, comments and orders are NOT transferred just because the said flags have not been enabled. This is no longer true with respect to your pull request as now these options default to true regardless of these things are passed or not. Therefore, the testcases need to be changed to accompany those. I will limit myself to explaining only one such scenario and allow for you to explore the codebase so that you can find out more such testcases that need changing.

@brngylni
Copy link
Contributor Author

@brngylni, in the /test/ directory - you need to make changes to account for the changed option sets.

Take, for instance, these lines of code https://github.com/fedora-infra/pagure-exporter/blob/main/test/test_tkts.py#L37-L48 where it is assumed that the labels, states, privacy, comments and orders are NOT transferred just because the said flags have not been enabled. This is no longer true with respect to your pull request as now these options default to true regardless of these things are passed or not. Therefore, the testcases need to be changed to accompany those. I will limit myself to explaining only one such scenario and allow for you to explore the codebase so that you can find out more such testcases that need changing.

Thank you very much for the clarification. I've checked the test files and updated the commands accordingly. Hopefully there are no misses this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants