Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prost crates to 0.13 #68

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

nickpresta
Copy link
Contributor

@nickpresta nickpresta commented Jul 10, 2024

@nickpresta
Copy link
Contributor Author

@fdeantoni Don't intend to pressure you - just wanted to let you know this PR exists and ask whether there's anything else I need to do as part of this change (e.g. CHANGELOG entry). Thanks!

@fdeantoni
Copy link
Owner

Many thanks for putting this PR together! I will review and if all looks good will try to create a new release in the next few days.

@ytitov
Copy link

ytitov commented Jul 15, 2024

no pressure

@djc
Copy link

djc commented Jul 25, 2024

@fdeantoni friendly ping? Would be nice to get this released!

@fdeantoni
Copy link
Owner

Hi all, apologies for the delay! I will make sure to push out an update this weekend.

@fdeantoni fdeantoni merged commit da91279 into fdeantoni:master Jul 28, 2024
6 checks passed
@h7kanna
Copy link

h7kanna commented Jul 28, 2024

Should this be 0.6 release? Seems like updating the prost to 0.13 is breaking builds.

59   | #[derive(Clone, PartialEq, ::prost::Message)]
     |                            ^^^^^^^^^^^^^^^^ the trait `prost::Message` is not implemented for `prost_wkt_types::Duration`
     |
     = help: the following other types implement trait `prost::Message`:
               ()
               Acceptance
               Access
               AccountAccess
               ActivityExecutionResult
               ActivityFailureInfo
               ActivityHeartbeat
               ActivityPropertiesModifiedExternallyEventAttributes
             and 535 others
note: required by a bound in `prost::encoding::message::merge`
    --> /Users/h7kanna/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prost-0.12.6/src/encoding.rs:1075:12

@djc
Copy link

djc commented Jul 28, 2024

Yup, this should definitely get a semver-incompatible release (and you probably want to yank 0.5.2).

@fdeantoni
Copy link
Owner

Were all the dependencies updated to Prost 0.13 and prost-wkt to 0.5.2? Although Prost has gone to 0.13, the implementation of prost-wkt has not changed significantly, hence I kept it at 0.5. I realize now that this may cause problems and it should go to 0.6. I will yank this release and make it 0.6.0 instead. Apologies for all the trouble caused!

@fdeantoni
Copy link
Owner

Hi All, I have yanked 0.5.2 and released it as 0.6.0 instead. I've added a CHANGELOG.md to document this as well. Please test it out and if any other problems encountered do let me know!!

@h7kanna
Copy link

h7kanna commented Jul 29, 2024

prost-wkt-build needs to be yanked as well

[[package]]
name = "prost-wkt-build"
version = "0.5.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a06feedac9f90870ab1c46ac404cf3217ba42d220c62ff8f8119d4b1f685741c"
dependencies = [
 "heck 0.5.0",
 "prost 0.13.1",
 "prost-build 0.13.1",
 "prost-types 0.13.1",
 "quote",
]

@fdeantoni
Copy link
Owner

Apologies yes, prost-wkt-build and prost-wkt-types have been yanked now as well.

@h7kanna
Copy link

h7kanna commented Jul 29, 2024

All good now, Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prost 0.13 update
5 participants