Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prost from 0.11.9 to 0.12.0 #53

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Conversation

dragonnn
Copy link
Contributor

In my use case and by running test I didn't notice with pushing prost to 0.12.0 any problems.

@dsmith3197
Copy link

@fdeantoni Are there any blockers here? Can we get this merged soon?

@fdeantoni
Copy link
Owner

Many thanks for putting together this PR! I was planning to release a new version in the next two weeks. I did notice that Prost now has a version 0.12.1 (also in crates.io), so we might want to go straight for that one instead. Also need a little more time to investigate why the build fails at 1.62. It looks like minimum required will be 1.63 now...

@dragonnn
Copy link
Contributor Author

Just pushed prost up to 0.12.1. When it comes to MSRV I am perfectly fine with needing 1.63. In the project I am using prost-wkt I do use current stable and update it regularly so that doesn't affect me.

@Leulz
Copy link
Contributor

Leulz commented Sep 26, 2023

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.

Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but thought you all should know.

@dragonnn
Copy link
Contributor Author

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.

Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but thought you all should know.

No, this is just how rust works, when you pull current prost-wkt into a project that uses prost 0.12.1 you have two prost version in your project, 0.11 with prost-wkt implements and 0.12.1 with your project uses, so yes then you get errors of stuff not implemented because prost structs implement it for 0.11, not 0.12.
They where for sure some breaking changes in 0.12 with is why the version bump was made, but they don't affect prost-wkt.

@Leulz
Copy link
Contributor

Leulz commented Sep 26, 2023

FYI #54 has an error that is happening when one uses prost-wkt with the latest version of prost (0.12.1). I'm also having the same error.
Just saying this here to avoid potential problems with bumping the prost version of the crate. Maybe prost introduced a breaking change that does not have a test here to catch it? Not sure, but thought you all should know.

No, this is just how rust works, when you pull current prost-wkt into a project that uses prost 0.12.1 you have two prost version in your project, 0.11 with prost-wkt implements and 0.12.1 with your project uses, so yes then you get errors of stuff not implemented because prost structs implement it for 0.11, not 0.12. They where for sure some breaking changes in 0.12 with is why the version bump was made, but they don't affect prost-wkt.

I see, thanks for the reply! Hopefully we'll be having this PR merged soon, then. I introduced an implementation of TryFrom<i32> for prost's enums and wanted to use it in my projects.

@fdeantoni fdeantoni merged commit a79a54f into fdeantoni:master Sep 30, 2023
3 of 6 checks passed
@dsmith3197
Copy link

@fdeantoni Is there anything blocking releasing the new version on crates.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants