Make sure AutoCloseable resources are closed #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of auditing the codebase for resource leaks. Includes many fixes to unit tests that are likely unnecessary, but included for the sake of cleanliness
ajs6f
approved these changes
Aug 15, 2017
|
@birkland I'll try and test this in isolation before Islandora/Alpaca#42 to see if I can pin down precisely what's causing our issue. |
|
@dannylamb Great. Jenkins should finish and publish its snapshot build of API-X in a few minutes |
|
So this hasn't resolved the issue, but it has turned it from intermittent to easily reproducable. 👍 to that. |
|
That seems strange, but I'll take it. Also taking another look at the initial CLAW issue.. |
|
Easily repro is certainly good. And certainly weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of auditing the codebase for resource leaks. Includes
many fixes to unit tests that are likely unnecessary, but included for the sake
of cleanliness
Possibly related to #126