Use the labelme sizes instead of recomputing them #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of annotated images that have EXIF orientation, labelme would annotate the transformed image and provide the annotation coordinates in the re-oriented image. When computing the image sizes with `Image.open`, we ignore the EXIF orientation and thus save a different image dimension than the one in the labelme file (we swap the dimensions). Since we only use PIL to compute the image sizes and the labelme file provides these dimensions anyway, maybe we can just get away with using them.
|
@fcakyon hi! Thoughts on this PR? |
|
@fcakyon the test failures also seem to happen on the unchanged repository and are unlikely to come from this PR :'( |
|
@Dexterp37 currently tests are not correct so we cannot understand if your changes affect the results. I will just merge it, thank you for your contributions! |
Thank you for the great tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of annotated images that have EXIF orientation, labelme would annotate the transformed image and provide the annotation coordinates in the re-oriented image. When computing the image sizes with
Image.open, we ignore the EXIF orientation and thus save a different image dimension than the one in the labelme file (we swap the dimensions). Since we only use PIL to compute the image sizes and the labelme file provides these dimensions anyway, maybe we can just get away with using them.