Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: relicense code under Apache 2.0 with LLVM exceptions #952

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 28, 2024

@symgryph @JvdMaat I'm considering relicensing the entire project under the Apache 2.0 license with LLVM exceptions to improve compatibility with GPL 2.0 and many runtime license exceptions.

You've previously contributed to this project (thank you!), so I need your approval to proceed with relicensing. If you don't approve, I may need to remove or replace your contribution before relicensing.

Let's keep the process as simple as possible: to indicate your agreement, please approve this pull request.

I just went ahead and removed or replaced relevant parts.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (1ede6f4) to head (a6f9642).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files          62       62           
  Lines        2867     2867           
=======================================
  Hits         2748     2748           
  Misses        107      107           
  Partials       12       12           
Flag Coverage Δ
unittests 95.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia
Copy link
Owner Author

favonia commented Sep 30, 2024

Alright, I rewrote and removed all the parts I might not have the right to relicense. We can easily add things back. 😄

@favonia favonia enabled auto-merge (squash) September 30, 2024 05:54
@favonia favonia merged commit 48fd2d7 into main Sep 30, 2024
10 checks passed
@favonia favonia deleted the add-llvm-exceptions branch September 30, 2024 05:54
@JvdMaat
Copy link
Contributor

JvdMaat commented Sep 30, 2024

Looks like it's already approved.

@favonia
Copy link
Owner Author

favonia commented Sep 30, 2024

@JvdMaat I decided to rewrite the relevant parts in the README file without waiting for you 😅 Sorry about that!

@favonia
Copy link
Owner Author

favonia commented Sep 30, 2024

@JvdMaat Just to clarify, this PR was only approved by one of the copyright owners. You might also own the copyright of some part of the documentation. Therefore your approval was still needed before I rewrote the sentences. I still appreciate your contributions and kept your name in CONTRIBUTORS.markdown. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants