Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): warn about mismatched attributes #921

Merged
merged 6 commits into from
Sep 12, 2024
Merged

feat(api): warn about mismatched attributes #921

merged 6 commits into from
Sep 12, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 10, 2024

Close #840. Close #912.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 99.53052% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (086ed61) to head (9847e49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ddns/ddns.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   95.58%   95.67%   +0.08%     
==========================================
  Files          58       58              
  Lines        2583     2635      +52     
==========================================
+ Hits         2469     2521      +52     
  Misses        104      104              
  Partials       10       10              
Flag Coverage Δ
unittests 95.67% <99.53%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia merged commit 80388a0 into main Sep 12, 2024
10 checks passed
@favonia favonia deleted the warn-mismatch branch September 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy status of DNS records was not updated Detect mismatched record configurations
1 participant