Skip to content

Commit

Permalink
fix: put annotations only within the index manifest (#659)
Browse files Browse the repository at this point in the history
After digging into the source code of ArtifactHub, I believe
it doesn't make much sense to add ArtifactHub-specific
annotations within individual image manifests. What should
be changed is ArtifactHub, not this tool.

Since GitHub registry also expects annotations at the
index level. 'manifest' was removed. This is partially
reverting PR #652.
  • Loading branch information
favonia committed Dec 5, 2023
1 parent 0b1dd4c commit 687ccaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
io.artifacthub.package.readme-url=https://github.com/raw/favonia/cloudflare-ddns/main/build/SUMMARY.markdown
io.artifacthub.package.maintainers=[{"name":"favonia","email":"favonia@email.com"}]
env:
DOCKER_METADATA_ANNOTATIONS_LEVELS: manifest,index
DOCKER_METADATA_ANNOTATIONS_LEVELS: index
- name: 🚀 Build and deploy minimal Docker images
uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56 # v5.1.0
id: build
Expand Down

0 comments on commit 687ccaa

Please sign in to comment.